Skip to content

Promote Namespaces field to a pointer#374

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
ingvagabund:namespace-as-pointer
Aug 14, 2020
Merged

Promote Namespaces field to a pointer#374
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
ingvagabund:namespace-as-pointer

Conversation

@ingvagabund
Copy link
Contributor

So when the data is serialized into a json, the field is omitted.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 13, 2020
Copy link
Member

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2020
@lixiang233
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit f5d8a02 into kubernetes-sigs:master Aug 14, 2020
@ingvagabund ingvagabund deleted the namespace-as-pointer branch August 14, 2020 16:24
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
…pointer

Promote Namespaces field to a pointer
ingvagabund pushed a commit to ingvagabund/descheduler that referenced this pull request Mar 3, 2026
…ces/release-4.20

chore(deps): update konflux references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants