E2E using gce first pass by ravisantoshgudimetla · Pull Request #31 · kubernetes-sigs/descheduler

ravisantoshgudimetla · 2017-10-30T17:33:28Z

@aveshagarwal I am able to create a 3 node cluster in gce with pod being evicted for lownodeutilization case. Please review when you find time. I believe, travis ci might complain because of encrypted file(client.json.enc) which will probably not be decrypted on this repo.

Some changes:

Now instead of running unit-tests, travis will run unit-tests + e2e's when using make test.
Before running make test, we need to ensure that gcloud_create_cluster.sh has been run. I have included that in the run-tests.sh(file renamed from run-unittests.sh)

Sample Output after running e2e:

evicting pods from node %#v with usage: %#v descheduler-b148f4c6-bd94-11e7-8e84-c85b76333877 map[cpu:2264 memory:263.78542244169597 pods:81.81818181818181]

aveshagarwal · 2017-10-30T17:39:10Z

@ravisantoshgudimetla thanks ravi, will look into it soon.

aveshagarwal · 2017-11-03T17:52:58Z

ok to test

ravisantoshgudimetla · 2017-11-03T18:09:37Z

ok to test

aveshagarwal · 2017-11-03T18:09:38Z

Can one of the admins verify this patch?

ravisantoshgudimetla · 2017-11-03T19:48:35Z

ok to test

ravisantoshgudimetla · 2017-11-03T20:13:22Z

retest this please

ravisantoshgudimetla · 2017-11-03T20:31:57Z

/test all

ravisantoshgudimetla · 2018-03-14T03:22:41Z

/test e2e

openshift-ci-robot · 2018-03-14T03:22:57Z

@ravisantoshgudimetla: you can't request testing unless you are a kubernetes-incubator member.

Details

In response to this:

/test e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aveshagarwal · 2018-03-14T03:36:13Z

@ravisantoshgudimetla this PR updates vendor dir, but where are changes to glide.lock file?

ravisantoshgudimetla · 2018-03-14T11:20:42Z

@aveshagarwal I removed the dependency on those vendored files. I copied the function which I need to the test so it should run independently.

ingvagabund · 2018-03-15T11:41:51Z

/test e2e

ingvagabund · 2018-03-16T11:14:47Z

/test e2e

ingvagabund · 2018-03-16T11:28:00Z

hack/e2e-gce/gcloud_create_cluster.sh

+	gcloud compute copy-files  $E2E_GCE_HOME/kubeadm_preinstall.sh descheduler-$master_uuid:/tmp --zone=us-east1-b
+	gcloud compute copy-files $E2E_GCE_HOME/kubeadm_install.sh descheduler-$master_uuid:/tmp --zone=us-east1-b
+	gcloud compute copy-files  $E2E_GCE_HOME/kubeadm_preinstall.sh descheduler-$node1_uuid:/tmp --zone=us-east1-b
+	gcloud compute copy-files  $E2E_GCE_HOME/kubeadm_preinstall.sh descheduler-$node2_uuid:/tmp --zone=us-east1-b


WARNING: gcloud compute copy-files is deprecated. Please use gcloud compute scp instead. Note that gcloud compute scp does not have recursive copy on by default. To turn on recursion, use the --recurse flag.

Thanks for catching it. These were not deprecated when I wrote them back in October. I can add a TODO or update them.

ingvagabund · 2018-03-16T13:12:46Z

/test e2e

ingvagabund · 2018-03-16T14:56:50Z

/test e2e

ingvagabund · 2018-03-16T17:11:42Z

/test e2e

ingvagabund · 2018-03-16T18:04:56Z

CI job merged.

aveshagarwal · 2018-03-19T14:49:45Z

@ingvagabund @ravisantoshgudimetla is it ready for merge?

ravisantoshgudimetla · 2018-03-19T14:50:07Z

@ingvagabund can you give a LGTM so that @aveshagarwal can merge?

ingvagabund · 2018-03-19T13:06:40Z

hack/e2e-gce/install_gcloud.sh

@@ -0,0 +1,9 @@
+#!/usr/bin/env bash


NIT: Currently the file is not needed. Installation of the gcloud is part of the JJ [1].

[1] https://github.com/openshift/aos-cd-jobs/blob/master/sjb/config/test_cases/ci-kubernetes-descheduler-e2e-gce.yml#L12-L23

ingvagabund · 2018-03-19T13:08:52Z

hack/e2e-gce/gcloud_sdk_configure.sh

@@ -0,0 +1,8 @@
+#!/usr/bin/env bash


NIT: The script is not invoked anywhere. Maybe make it part of some documentation that describes how to setup and run the descheduler e2e tests?

This is needed if someone wants to run e2e using GCE from local system. This is similar to kube-up.sh in upstream.

ingvagabund · 2018-03-19T15:00:00Z

test/e2e/e2e_test.go

+	if err != nil {
+		t.Errorf("Error listing node with %v", err)
+	}
+	leastLoadedNode := nodeList.Items[2]


Nit: We should check if the cluster has at least 3 nodes. Otherwise this will panic.

Btw. how do you know the third node in the list is actually the least loaded node?

Nit: We should check if the cluster has at least 3 nodes. Otherwise this will panic.

We would have failed in gcloud_cluster_create.sh if we don't have 3 nodes. I thought failing early is better.

Btw. how do you the third node in the list is actually the least loaded node?

I have added a comment here.

https://github.com/kubernetes-incubator/descheduler/pull/31/files/e0d3b2663509dde3266daed9ecd0867f6fc4fdb0#diff-6413e1dbafd6dd63b5d907ea3ae6f6f9R151

Ok, let's put the comment here. Smth like:

// Assumption: kubeadm brings all the master components onto master node. So, the last node would have least utilization.

ingvagabund · 2018-03-19T15:36:04Z

/lgtm

…ream bug 1836971: Sync with upstream

…ith_travis_gcloud E2E using gce first pass

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 30, 2017

ravisantoshgudimetla force-pushed the e2e_with_travis_gcloud branch 4 times, most recently from c827f92 to 897f314 Compare October 31, 2017 19:10

ravisantoshgudimetla mentioned this pull request Nov 1, 2017

[WIP] End to testing PR #12

Closed

ravisantoshgudimetla force-pushed the e2e_with_travis_gcloud branch 3 times, most recently from 0dbc5e8 to 3f549cf Compare November 3, 2017 16:51

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 3, 2017

ravisantoshgudimetla force-pushed the e2e_with_travis_gcloud branch 3 times, most recently from 7d28eaa to 27cc1cd Compare November 3, 2017 19:29

ravisantoshgudimetla assigned aveshagarwal Nov 3, 2017

ravisantoshgudimetla force-pushed the e2e_with_travis_gcloud branch 5 times, most recently from cb39760 to 9a2e9ac Compare November 29, 2017 20:46

ravisantoshgudimetla closed this Nov 29, 2017

ravisantoshgudimetla reopened this Nov 29, 2017

ravisantoshgudimetla force-pushed the e2e_with_travis_gcloud branch from efff065 to 42d71f7 Compare March 14, 2018 01:58

ravisantoshgudimetla force-pushed the e2e_with_travis_gcloud branch from 42d71f7 to b599802 Compare March 14, 2018 10:38

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 14, 2018

ravisantoshgudimetla force-pushed the e2e_with_travis_gcloud branch from b599802 to 616d4f8 Compare March 14, 2018 10:51

ingvagabund reviewed Mar 16, 2018

View reviewed changes

ravisantoshgudimetla force-pushed the e2e_with_travis_gcloud branch from 616d4f8 to e0d3b26 Compare March 16, 2018 13:52

ingvagabund reviewed Mar 19, 2018

View reviewed changes

ravisantoshgudimetla force-pushed the e2e_with_travis_gcloud branch from e0d3b26 to 16a452e Compare March 19, 2018 15:31

E2E using gce first pass

de76f9b

ravisantoshgudimetla force-pushed the e2e_with_travis_gcloud branch from 16a452e to de76f9b Compare March 19, 2018 15:34

k8s-ci-robot assigned ingvagabund Mar 19, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2018

aveshagarwal merged commit 0a7f14d into kubernetes-sigs:master Mar 19, 2018

ingvagabund pushed a commit to ingvagabund/descheduler that referenced this pull request May 29, 2020

Merge pull request kubernetes-sigs#31 from ingvagabund/sync-with-upst…

bc98f48

…ream bug 1836971: Sync with upstream

RyanDevlin mentioned this pull request Mar 30, 2021

Added EvictSystemCriticalPods flag to descheduler #523

Merged

briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022

Merge pull request kubernetes-sigs#31 from ravisantoshgudimetla/e2e_w…

e1be086

…ith_travis_gcloud E2E using gce first pass

Conversation

ravisantoshgudimetla commented Oct 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aveshagarwal commented Oct 30, 2017

Uh oh!

aveshagarwal commented Nov 3, 2017

Uh oh!

ravisantoshgudimetla commented Nov 3, 2017

Uh oh!

aveshagarwal commented Nov 3, 2017

Uh oh!

ravisantoshgudimetla commented Nov 3, 2017

Uh oh!

ravisantoshgudimetla commented Nov 3, 2017

Uh oh!

ravisantoshgudimetla commented Nov 3, 2017

Uh oh!

ravisantoshgudimetla commented Mar 14, 2018

Uh oh!

openshift-ci-robot commented Mar 14, 2018

Uh oh!

aveshagarwal commented Mar 14, 2018

Uh oh!

ravisantoshgudimetla commented Mar 14, 2018

Uh oh!

ingvagabund commented Mar 15, 2018

Uh oh!

ingvagabund commented Mar 16, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ravisantoshgudimetla Mar 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ingvagabund commented Mar 16, 2018

Uh oh!

ingvagabund commented Mar 16, 2018

Uh oh!

ingvagabund commented Mar 16, 2018

Uh oh!

ingvagabund commented Mar 16, 2018

Uh oh!

aveshagarwal commented Mar 19, 2018

Uh oh!

ravisantoshgudimetla commented Mar 19, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ingvagabund Mar 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ingvagabund commented Mar 19, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ravisantoshgudimetla commented Oct 30, 2017 •

edited

Loading

ravisantoshgudimetla Mar 16, 2018 •

edited

Loading

ingvagabund Mar 19, 2018 •

edited

Loading