-
Notifications
You must be signed in to change notification settings - Fork 680
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
and remove local helm testing in favor of ct in PRs
- Loading branch information
1 parent
0d1d485
commit a08c28d
Showing
7 changed files
with
48 additions
and
91 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
chart-dirs: | ||
- charts | ||
helm-extra-args: "--timeout=5m" | ||
helm-extra-set-args: "--set=kind=Deployment --set=podSecurityPolicy.create=false" | ||
check-version-increment: false | ||
target-branch: master |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,9 +7,11 @@ on: | |
- release-* | ||
paths: | ||
- 'charts/**' | ||
- '.github/workflows/helm.yaml' | ||
pull_request: | ||
paths: | ||
- 'charts/**' | ||
- '.github/workflows/helm.yaml' | ||
|
||
jobs: | ||
lint-and-test: | ||
|
@@ -23,14 +25,16 @@ jobs: | |
- name: Set up Helm | ||
uses: azure/[email protected] | ||
with: | ||
version: v3.4.2 | ||
version: v3.9.2 | ||
|
||
- uses: actions/[email protected] | ||
with: | ||
python-version: 3.7 | ||
|
||
- name: Set up chart-testing | ||
uses: helm/[email protected] | ||
with: | ||
version: v3.7.0 | ||
|
||
- name: Run chart-testing (list-changed) | ||
id: list-changed | ||
|
@@ -39,6 +43,35 @@ jobs: | |
if [[ -n "$changed" ]]; then | ||
echo "::set-output name=changed::true" | ||
fi | ||
# Force linting/test in debug runs with a change (this action only runs on chart and helm.yaml workflow diffs anyways) | ||
- name: Change Kind to deployment | ||
run: "sed -i \"s|kind: [^ ]*|kind: Deployment|g\" charts/descheduler/values.yaml" | ||
|
||
- name: Run chart-testing (lint) | ||
run: ct lint --config=.github/ci/ct.yaml --validate-maintainers=false | ||
|
||
# Need a multi node cluster so descheduler runs until evictions | ||
- name: Create multi node Kind cluster | ||
run: | | ||
cat > kind-config.yaml <<EOF | ||
# three node (two workers) cluster config | ||
kind: Cluster | ||
apiVersion: kind.x-k8s.io/v1alpha4 | ||
nodes: | ||
- role: control-plane | ||
- role: worker | ||
- role: worker | ||
EOF | ||
kind create cluster --name kind --config kind-config.yaml --wait 2m | ||
# helm-extra-set-args only available after ct 3.6.0 | ||
- name: Run chart-testing (install) | ||
run: ct install --config=.github/ci/ct.yaml | ||
|
||
- name: E2E after chart install | ||
env: | ||
KUBERNETES_VERSION: "v1.24.0" | ||
KIND_E2E: true | ||
SKIP_INSTALL: true | ||
run: make test-e2e |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 0 additions & 30 deletions
30
charts/descheduler/templates/tests/test-descheduler-pod.yaml
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.