-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add swap column to crictl stats #1674
base: master
Are you sure you want to change the base?
Conversation
/hold Going to test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
It will be 0
most times unless somebody enabled it. So it is good to have it as a last column.
I got hit with a vagrant bug in the latest that is making it difficult to confirm this works. I was able to see the column. |
great. I was wondering how it will behave when there is no swap. It should panic or anything |
We always show swap in the stats (crictl stats -output=json) will show that it is 0. From what I saw it was reporting zero. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add Swap to
crictl stats
display.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?