Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: Don't flatten schemas for type idents we don't know about #627

Commits on Sep 29, 2021

  1. fix: Don't flatten schemas for type idents we don't know about

    I hit this problem with cases where there are multiple packages with the
    same group and version. The schema patcher would hit a nil pointer
    trying to flatten a schema for a kind that exists in one package, but
    not another, because it seems to assume that everything's in one
    package. By skipping cases where the parser hasn't already found the
    given kind in the given package, we got past that panic and everything
    works correctly.
    
    I believe this should address kubernetes-sigs#624, though I can't be sure if this is
    the only path that can lead to that panic.
    
    Signed-off-by: Andrew Bayer <[email protected]>
    abayer committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    8eda5d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Default to erroring for groups in multiple packages, with option to a…

    …llow instead
    
    Signed-off-by: Andrew Bayer <[email protected]>
    abayer committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    0437e6a View commit details
    Browse the repository at this point in the history