🐛 Allow floating-point values in validations #619

Porges · 2021-09-19T23:45:48Z

Closes #543. We have also run into this while working on https://github.com/Azure/azure-service-operator.

Extend marker parser to allow parsing float/JSON number values.
Allow validations for Minimum, Maximum, and MultipleOf to have float values when applied to float fields.

Actual use of float fields is still restricted by the allowDangerousTypes flag, so no further restrictions are needed as part of this change.

k8s-ci-robot · 2021-09-19T23:45:55Z

Hi @Porges. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-triage-robot · 2021-12-19T01:53:36Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-01-18T01:55:19Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

Porges · 2022-01-19T20:05:58Z

/remove-lifecycle rotten

bad bot

matthchr · 2022-03-10T00:16:56Z

It would be nice to get this merged. It's been open for a while.

…lidation

erikgb

Did a quick scan. Looks reasonable to me, but I am not too familiar with this codebase.

/ok-to-test

pkg/markers/parse.go

pkg/crd/parser_integration_test.go

AlmogBaku · 2022-04-29T10:09:39Z

Hi, Thanks for your contribution!

Overall it looks good to me, I'm just wondering about this "AllowDangerousTypes" that you also added in the marker

AlmogBaku · 2022-04-29T13:02:02Z

/lgtm

pkg/markers/parse.go

joelanford · 2022-04-29T17:16:18Z

For some nits:
/hold

But its nothing to block merging over, so:
/approve

If you want to accept the nits, ping me again and I can re-add lgtm and approve labels.

Co-authored-by: Joe Lanford <[email protected]>

Porges · 2022-05-01T20:37:53Z

@AlmogBaku Overall it looks good to me, I'm just wondering about this "AllowDangerousTypes" that you also added in the marker

It’s required in order to use float values at all in the test file.

erikgb · 2022-05-01T21:45:40Z

/lgtm

joelanford · 2022-05-01T23:37:38Z

/approve

k8s-ci-robot · 2022-05-01T23:37:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlmogBaku, joelanford, Porges

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [joelanford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

joelanford · 2022-05-02T01:23:54Z

/hold cancel

Porges · 2022-05-02T21:08:05Z

Thanks for reviewing @joelanford

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 19, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 19, 2021

k8s-ci-robot requested review from droot and mengqiy September 19, 2021 23:45

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 19, 2021

Porges changed the title ~~Allow floating-point values in validations~~ 🐛 Allow floating-point values in validations Sep 19, 2021

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2021

Allow floating-point values in validations

618e68e

Porges force-pushed the floating-point-validation branch from 5e209fb to 618e68e Compare September 20, 2021 01:40

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2021

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 19, 2021

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 18, 2022

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 19, 2022

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2022

Merge remote-tracking branch 'upstream/master' into floating-point-va…

62ad93a

…lidation

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2022

Fix 'go generate' invocation

8f0e6d3

erikgb reviewed Apr 28, 2022

View reviewed changes

pkg/markers/parse.go Show resolved Hide resolved

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2022

AlmogBaku reviewed Apr 29, 2022

View reviewed changes

pkg/crd/parser_integration_test.go Show resolved Hide resolved

k8s-ci-robot assigned AlmogBaku Apr 29, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2022

AlmogBaku approved these changes Apr 29, 2022

View reviewed changes

joelanford reviewed Apr 29, 2022

View reviewed changes

pkg/markers/parse.go Outdated Show resolved Hide resolved

joelanford reviewed Apr 29, 2022

View reviewed changes

pkg/markers/parse.go Outdated Show resolved Hide resolved

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 29, 2022

Order values better

7fc2acb

Co-authored-by: Joe Lanford <[email protected]>

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2022

else if → if

4b99330

Co-authored-by: Joe Lanford <[email protected]>

k8s-ci-robot assigned erikgb May 1, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2022

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2022

k8s-ci-robot merged commit cb13ac5 into kubernetes-sigs:master May 2, 2022

Porges deleted the floating-point-validation branch May 2, 2022 21:07

🐛 Allow floating-point values in validations #619

🐛 Allow floating-point values in validations #619

Uh oh!

Conversation

Porges commented Sep 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Sep 19, 2021

Uh oh!

k8s-triage-robot commented Dec 19, 2021

Uh oh!

k8s-triage-robot commented Jan 18, 2022

Uh oh!

Porges commented Jan 19, 2022

Uh oh!

matthchr commented Mar 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erikgb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AlmogBaku commented Apr 29, 2022

Uh oh!

AlmogBaku commented Apr 29, 2022

Uh oh!

Uh oh!

Uh oh!

joelanford commented Apr 29, 2022

Uh oh!

Porges commented May 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erikgb commented May 1, 2022

Uh oh!

joelanford commented May 1, 2022

Uh oh!

k8s-ci-robot commented May 1, 2022

Uh oh!

joelanford commented May 2, 2022

Uh oh!

Porges commented May 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Porges commented Sep 19, 2021 •

edited

Loading

matthchr commented Mar 10, 2022 •

edited

Loading

Porges commented May 1, 2022 •

edited

Loading