🐛 fix windows filepath compatibility

[alexeldeib]

Fixes #152, enables Kubebuilder Windows releases.

[DirectXMan12]

It seems like you missed a few (there's a couple of spots that're still path.Join)

[alexeldeib]

@DirectXMan12 I took the slimmest possible cut to make this functional. Is it safe to assume we'd like to change all of these to filepath and not path? I'll align the rest if so.

[alexeldeib]

Per kubernetes-sigs/kubebuilder#661 (comment), I'm going to revert to the initial cut using fewer filepath calls. I don't see a point switching back and forth on filepath separators except where it's necessary.

Maybe I should really be aligning the strings.HasPrefix() calls + paths at the same time to make it a non-issue? It's the mismatch between Go imports, HasPrefix, and Windows that is causing the problem anyway.

Meh, a good number of these are actually filepaths.

[alexeldeib]

@DirectXMan12 let me know the preferred route on this and I can implement it. Sorry to nag you, would love to get full releases of kubebuilder enabled for windows 😄

[DirectXMan12]

/lgtm
/approve

[DirectXMan12]

/hold

[DirectXMan12]

setAPIsPath still has some weirdness, no? I think you need to convert to a OS path when calling stat, but leave as a normal path otherwise?

[alexeldeib]

Nice catch, fixed on the os.Stat.

[DirectXMan12]

/lgtm
/approve

/hold cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeldeib, DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [DirectXMan12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[DirectXMan12]

thanks!