-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 rbac: fix adding nonResourceURLs including normalisation #1044
Conversation
Thx! /lgtm /test pull-controller-tools-test-master |
@sbueringer: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
LGTM label has been added. Git tree hash: ef6decf5935fc4c5b0a8fd97bf141fd7825615df
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.16 |
@rakesh-garimella Do you have some time to verify the fix on your side as well? I would then cut a new patch release |
@sbueringer: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Just remembered that we don't always use release branches in CT, which is also the reason why we don't have one yet. I would also cut this patch release directly from main, because apart from a few bug fixes nothing was changed on CT main since v0.16 & v0.16.1. (we only have pre-submit jobs set up for the main branch in CT) |
thanks @sbueringer I will give it a try |
The fix works for me, thanks again @chrischdi @sbueringer |
Thx again for reporting! |
Fixes the rbac generator for nonResourceURLs / when using
kubebuilder:rbac:urls
marker.Kudos to @rakesh-garimella for reporting it at #937
This propably broke when implementing #937
@sbueringer : I think this is ok to cherry-pick?