-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix duplicate default value when generating CRDs with corev1.Protocol #1035
🐛 Fix duplicate default value when generating CRDs with corev1.Protocol #1035
Conversation
Signed-off-by: Stefan Büringer [email protected]
/hold |
/assign @chrischdi @alvaroaleman @vincepri |
Signed-off-by: Stefan Büringer [email protected]
Signed-off-by: Stefan Büringer [email protected]
26fb110
to
2f6801d
Compare
LGTM label has been added. Git tree hash: 856212f4c4f196f5b341757498aa5e8b463153ce
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel Thx for the quick review! |
The protocol schema was hard-coded, because of that now that the "default" marker works we are ending up with all of.
Simple example:
leads to
This PR contains 3 commits:
Fixes #1027