Running controller-tools over k8s.io/api/core/v1.PodSpec fails

[dprotaso]

Here the marker mapType is on a map[string]string
https://github.com/kubernetes/api/blob/b98f264fe39f5b5393bf918d8c16f86527965f1c/core/v1/types.go#L3129-L3132

Running controller-tools over this field results in a warning/error

k8s.io/api/core/v1/types.go:3129:2: must apply mapType to an object

[dprotaso]

I was testing this against master@529c857f74b225412836567200cd0ae003fbb3b3

And it still reproduces when I rebased with #692 - so master@6bfa604a52c3515580a919f6265e23f37b2d5632

[dprotaso]

Full error - ran against k8s api version v0.23.5

[some-local-path]/k8s.io/api/core/v1/types.go:3129:2: must apply mapType to an object
[some-local-path]/k8s.io/api/core/v1/types.go:3273:2: must apply listType to an array, found
[some-local-path]/k8s.io/api/core/v1/types.go:3273:2: must apply listMapKey to an array, found
[some-local-path]/k8s.io/api/core/v1/types.go:3273:2: must apply listMapKey to an array, found
Error: not all generators ran successfully

Process exits with exit code 1

[dprotaso]

Here are the fields with the markers

must apply mapType to an object

	// NodeSelector is a selector which must be true for the pod to fit on a node.
	// Selector which must match a node's labels for the pod to be scheduled on that node.
	// More info: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/
	// +optional
	// +mapType=atomic
	NodeSelector map[string]string `json:"nodeSelector,omitempty" protobuf:"bytes,7,rep,name=nodeSelector"`

must apply listType to an array, found
must apply listMapKey to an array, found
must apply listMapKey to an array, found

	// TopologySpreadConstraints describes how a group of pods ought to spread across topology
	// domains. Scheduler will schedule pods in a way which abides by the constraints.
	// All topologySpreadConstraints are ANDed.
	// +optional
	// +patchMergeKey=topologyKey
	// +patchStrategy=merge
	// +listType=map
	// +listMapKey=topologyKey
	// +listMapKey=whenUnsatisfiable
	TopologySpreadConstraints []TopologySpreadConstraint `json:"topologySpreadConstraints,omitempty" patchStrategy:"merge" patchMergeKey:"topologyKey" protobuf:"bytes,33,opt,name=topologySpreadConstraints"`

[dprotaso]

Note - this is the schema patcher

[dprotaso]

false - alarm - it's my changes