⚠️ Fakeclient: reject create/update if Name isn't provided

[GrigoriyMikhalkin]

Fixes #838

[k8s-ci-robot]

Hi @GrigoriyMikhalkin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alvaroaleman]

Thanks! Could you change the title prefix to :warning: so that ppl are aware that this is a breaking change, as it will break all tests that do not provide a name?

[GrigoriyMikhalkin]

Thanks! Could you change the title prefix to :warning: so that ppl are aware that this is a breaking change, as it will break all tests that do not provide a name?

Done

[alvaroaleman]

This needs to be a NewInvalid, this is how that looks like from a real api server:

              ErrStatus: {
                  TypeMeta: {Kind: "", APIVersion: ""},
                  ListMeta: {
                      SelfLink: "",
                      ResourceVersion: "",
                      Continue: "",
                      RemainingItemCount: nil,
                  },
                  Status: "Failure",
                  Message: "ConfigMap \"\" is invalid: metadata.name: Required value: name or generateName is required",
                  Reason: "Invalid",
                  Details: {
                      Name: "",
                      Group: "",
                      Kind: "ConfigMap",
                      UID: "",
                      Causes: [
                          {
                              Type: "FieldValueRequired",
                              Message: "Required value: name or generateName is required",
                              Field: "metadata.name",
                          },
                      ],
                      RetryAfterSeconds: 0,
                  },
                  Code: 422,
              }

[alvaroaleman]

/lgtm

[alvaroaleman]

/assign @vincepri

[vincepri]

/ok-to-test

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GrigoriyMikhalkin, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment