⚠️ Fakeclient: Reject Update with outdated ResourceVersion#832
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom Mar 26, 2020
Conversation
k8s-ci-robot
added
cncf-cla: yes
alvaroaleman
commented
Feb 27, 2020
djzager
reviewed
Feb 27, 2020
Contributor
djzager
left a comment
djzager
left a comment
There was a problem hiding this comment.
Couple of nits. Will look again later.
djzager
reviewed
Feb 27, 2020
alvaroaleman
force-pushed
the
fakeclient-refuse-update-with-outdated-rv
branch
from
e4eef7d to
052af23
Compare
djzager
approved these changes
Feb 28, 2020
Member
|
/milestone v0.6.0 |
k8s-ci-robot
added
do-not-merge/hold
Member
|
Holding for v0.6 |
mengqiy
reviewed
Mar 3, 2020
mengqiy
reviewed
Mar 3, 2020
alvaroaleman
force-pushed
the
fakeclient-refuse-update-with-outdated-rv
branch
from
052af23 to
25ef372
Compare
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, mengqiy, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the fakeclient to:
Note that while this brings the fakeclient more in line with a real client, it is a breaking change and has a good chance of breaking ppls tests.
/assign @vincepri