✨ Implement delete collection via delete options#447
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom Jul 26, 2019
Merged
✨ Implement delete collection via delete options#447k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Contributor
|
/hold while I be frustrating and indecisive. Don't want to make you miserable by going back and forth with myself :-P |
k8s-ci-robot
added
the
do-not-merge/hold
Contributor
|
(this is on the KB 2.0.0 cross-project tracking board though, so we'll get it in before then) |
DirectXMan12
force-pushed
the
feature.delete-collection
branch
from
dd782cd to
acf910d
Compare
k8s-ci-robot
added
size/XL
Contributor
|
rebased on top of #536 and edited for wording. Should be good to go once that merged. Sorry for all the back and forth |
DirectXMan12
force-pushed
the
feature.delete-collection
branch
from
acf910d to
7ca16cb
Compare
k8s-ci-robot
added
the
needs-rebase
implement `CollectionOptions` in `DeleteOptions` that allow to issue a `DeleteCollection` call under the hood add tests + examples Co-Authored-By: Aaron Clawson <Aaron.Clawson@gmail.com> Edited-By: Solly Ross (directxman12)
DirectXMan12
force-pushed
the
feature.delete-collection
branch
from
7ca16cb to
3b06668
Compare
k8s-ci-robot
added
size/L
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
/lgtm |
droot
added
approved
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: adracus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Yay!!! Feels good to get this merged. This completes the client interface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implement
CollectionOptionsinDeleteOptionsthat allow to issue aDeleteCollectioncall under the hoodadd tests + examples
Co-Authored-By: Aaron Clawson Aaron.Clawson@gmail.com
Edited By directxman12: function naming, rebase