✨ Add Limit and Continue functional list options for client#341
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom Sep 17, 2019
Merged
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
Contributor
Author
|
@DirectXMan12 PTAL. Not quite sure about what changes to make for the fake client though, so any pointers are appreciated. |
rajathagasthya
force-pushed
the
listoptions-310
branch
from
fb4659d to
fce0993
Compare
DirectXMan12
suggested changes
Feb 27, 2019
Contributor
DirectXMan12
left a comment
DirectXMan12
left a comment
There was a problem hiding this comment.
small nits inline, otherwise good work 👍
Contributor
|
if you really want to try and implement limit and continue in the fake client, that'd be ok, but I think since not everything supports limit and continue, we can just leave the fake client as-is. |
rajathagasthya
force-pushed
the
listoptions-310
branch
from
fce0993 to
2aaefc3
Compare
rajathagasthya
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
@DirectXMan12 Can you take a look when you get a chance? |
DirectXMan12
suggested changes
Jun 7, 2019
Contributor
DirectXMan12
left a comment
DirectXMan12
left a comment
There was a problem hiding this comment.
minor comments inline, otherwise looks good.
sorry for the review lag!
rajathagasthya
force-pushed
the
listoptions-310
branch
2 times, most recently
from
a5965da to
abec8be
Compare
rajathagasthya
force-pushed
the
listoptions-310
branch
from
abec8be to
6462b88
Compare
k8s-ci-robot
added
size/XL
Contributor
Author
|
Rebased on top of #536 |
rajathagasthya
force-pushed
the
listoptions-310
branch
from
6462b88 to
3137e0d
Compare
k8s-ci-robot
added
size/L
rajathagasthya
force-pushed
the
listoptions-310
branch
from
3137e0d to
8f10214
Compare
Adds Limit and Continue list options for pagination. Note that this change does not support setting Limit and Continue for `DeleteAllOfOptions` via functional options since it is not supported by the server.
rajathagasthya
force-pushed
the
listoptions-310
branch
from
8f10214 to
b5dfbb5
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
Contributor
Author
|
/assign @DirectXMan12 |
Contributor
|
/lgtm /retest |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adohe, DirectXMan12, rajathagasthya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
Fix typo in book: flag is --owner, not --owners
Member
|
Does |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #310