-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 envtest: improve process cleanup #2560
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
e03cc2a
to
b3737d7
Compare
b3737d7
to
12375c4
Compare
When envtest creates new processes, it wasn't setting the process group to the parent, when the main process is killed or it panics, all the other processes are orphaned, and need to be killed separately. In addition, if for some reason we can't shutdown a process cleanly, we should try to SIGKILL before returning from Stop. Signed-off-by: Vince Prignano <[email protected]>
12375c4
to
b10b858
Compare
@alvaroaleman @ncdc ptal |
/lgtm |
When envtest creates new processes, it wasn't setting the process group to the parent, when the main process is killed or it panics, all the other processes are orphaned, and need to be killed separately.
In addition, if for some reason we can't shutdown a process cleanly, we should try to SIGKILL before returning from Stop.
/assign @alvaroaleman