⚠ builder: return error when multiple reconcilers are set #2415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just saw this and was confused why we would want this behavior. I also looked at #1021 but I don't understand the reasoning.
If we want a silent overwrite behavior I would have expected Build/Complete to overwrite the reconciler from the previous set ctrlOptions not the other way around
I think this implementation still covers the original ask, folks can pass in a
nil
reconciler to Build/Complete