[release-0.15] 🐛 fix unspecified KindsFor version #2347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alvaro Aleman <[email protected]>
k8s-ci-robot
added
size/M
alvaroaleman
added
the
tide/merge-method-squash
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k8s-infra-cherrypick-robot, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
vincepri
reviewed
May 24, 2023
Comment on lines
+157
to
+158
| if len(versions) == 1 && versions[0] == "" { | ||
| versions = nil |
There was a problem hiding this comment.
Maybe a follow up, instead of checking the length, should we strip any version in the slice (vararg) that is an empty string instead?
renovate bot
referenced
this pull request
in open-feature/flagd
Aug 5, 2023
) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | require | patch | `v0.15.0` -> `v0.15.1` | --- ### Release Notes <details> <summary>kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)</summary> ### [`v0.15.1`](https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.1) [Compare Source](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.15.0...v0.15.1) #### What's Changed - \[release-0.15] ✨Fix logs in unstructured client by [@​k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2344](https://github.com/kubernetes-sigs/controller-runtime/pull/2344) - \[release-0.15] 🐛 fix unspecified KindsFor version by [@​k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2347](https://github.com/kubernetes-sigs/controller-runtime/pull/2347) - \[release-0.15] 🐛 fakeClient.Status().Update(...) cannot recognize resource version conflicts by [@​k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2372](https://github.com/kubernetes-sigs/controller-runtime/pull/2372) - \[release-0.15] 🐛 hasLabels and matchingLabels step on each other by [@​k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2373](https://github.com/kubernetes-sigs/controller-runtime/pull/2373) - \[release-0.15] 🐛 Fix Defaulting of the User Agent by [@​alvaroaleman](https://github.com/alvaroaleman) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2436](https://github.com/kubernetes-sigs/controller-runtime/pull/2436) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.15.0...v0.15.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNy4xIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2346
/assign sbueringer