Skip to content

⚠️ Fix broken kind logging #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2022
Merged

⚠️ Fix broken kind logging #1954

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a02d631
Fix broken kind logging
Jul 13, 2022
bb36890
fixup! Fix broken kind logging
Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/builder/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,13 +315,13 @@ func (blder *Builder) doController(r reconcile.Reconciler) error {
"controllerKind", gvk.Kind,
)

lowerCamelCaseKind := strings.ToLower(gvk.Kind[:1]) + gvk.Kind[1:]
kind := gvk.Kind

ctrlOptions.LogConstructor = func(req *reconcile.Request) logr.Logger {
log := log
if req != nil {
log = log.WithValues(
lowerCamelCaseKind, klog.KRef(req.Namespace, req.Name),
kind, klog.KRef(req.Namespace, req.Name),
Copy link
Contributor

@FillZpp FillZpp Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So why not just use gvk.Kind?

Copy link
Contributor Author

@tatsuhiro-t tatsuhiro-t Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed via bb36890

"namespace", req.Namespace, "name", req.Name,
)
}
Expand Down