✨ Add an option to set ReleaseOnCancel for leader election

[Danil-Grigorev]

Allow to specify ReleaseOnCancel option in manager.Options which gives an opportunity to reduce writes at etcd in idle for acquiring leader-election resource lock. Gives an ability to increase the values for LeaseDuration, RenewDeadline, and RetryPeriod, and not experience long pod downtimes at the times when the leader replica was downscaled, and a new one is still waiting for LeaseDuration to attempt to become one.

Copying implementation from openshift/cloud-credential-operator#231, thanks to @dgoodwin, who implemented it first.

[k8s-ci-robot]

Hi @Danil-Grigorev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Danil-Grigorev
To complete the pull request process, please assign joelanford
You can assign the PR to them by writing /assign @joelanford in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

/ok-to-test

[Danil-Grigorev]

@dgoodwin PTAL, would appreciate your opinion on this.

[alvaroaleman]

What are the odds? I created a PR for the same thing a couple of days back: #1126

I believe my PR has a better description of the implications of this, WDYT?

[JoelSpeed]

@alvaroaleman I've just checked over your PR and agree, the comment there is better IMO, changes are pretty identical otherwise 😅

[Danil-Grigorev]

Closing this - dup. #1126 :) Thanks @alvaroaleman!