Merge pull request #2809 from k8s-infra-cherrypick-robot/cherry-pick-…

…2806-to-release-0.18 [release-0.18] 🐛 correct kind source type
kubernetes-sigs · May 1, 2024 · cd2885e · cd2885e
2 parents d6feaae + 06acde3
commit cd2885e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/pkg/internal/source/internal_test.go b/pkg/internal/source/internal_test.go
@@ -286,6 +286,15 @@ var _ = Describe("Internal", func() {
 			instance.OnDelete(Foo{})
 		})
 	})
+
+	Describe("Kind", func() {
+		It("should return kind source type", func() {
+			kind := internal.Kind[*corev1.Pod]{
+				Type: &corev1.Pod{},
+			}
+			Expect(kind.String()).Should(Equal("kind source: *v1.Pod"))
+		})
+	})
 })
 
 type Foo struct{}

diff --git a/pkg/internal/source/kind.go b/pkg/internal/source/kind.go
@@ -103,7 +103,7 @@ func (ks *Kind[T]) Start(ctx context.Context, queue workqueue.RateLimitingInterf
 }
 
 func (ks *Kind[T]) String() string {
-	if isNil(ks.Type) {
+	if !isNil(ks.Type) {
 		return fmt.Sprintf("kind source: %T", ks.Type)
 	}
 	return "kind source: unknown type"