Skip to content

Comments

Add davidewatson to cluster-api-admins list in OWNER_ALIASES.#894

Closed
davidewatson wants to merge 1 commit intokubernetes-sigs:masterfrom
davidewatson:owners
Closed

Add davidewatson to cluster-api-admins list in OWNER_ALIASES.#894
davidewatson wants to merge 1 commit intokubernetes-sigs:masterfrom
davidewatson:owners

Conversation

@davidewatson
Copy link
Contributor

What this PR does / why we need it:

Adds @davidewatson to cluster-api-admins in OWNER_ALIASES. This will be used for GitBook maintenance and assisting with other repository management responsibilities.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2019
@davidewatson
Copy link
Contributor Author

/assign @timothysc

@detiber
Copy link
Contributor

detiber commented Apr 12, 2019

+1 from me
/hold
hold for consensus

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2019
@vincepri
Copy link
Member

+1

@vincepri
Copy link
Member

@detiber @davidewatson Do you think we should merge this change with the other PR already open?

@davidewatson
Copy link
Contributor Author

I think that makes sense. Should we wait until Wednesday to ensure we have a consensus?

Copy link
Contributor

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update this to remove krousey, luxas, roberthbailey from clusterapi*, still leave luxas as scl-lead, but add JSB too.

They are not active or have moved on.

/approve
Please address comments then lgtm from me.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidewatson, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2019
@detiber
Copy link
Contributor

detiber commented Apr 17, 2019

If there are no objections to this pr or #884, I can add this change to #884.

@vincepri
Copy link
Member

Closing in favor of #884
/close

@k8s-ci-robot
Copy link
Contributor

@vincepri: Closed this PR.

Details

In response to this:

Closing in favor of #884
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants