-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Update CoreDNS tags and upgrade checks in e2e tests #6338
Conversation
Signed-off-by: Abhishek Agarwal <[email protected]>
|
Welcome @Ab-hishek! |
Hi @Ab-hishek. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/easycla |
Can somebody help me with the CLA signing? I did everything that is mentioned here -> https://github.com/kubernetes/community/blob/master/CLA.md. But still EasyCLA is not passing. |
/check-cla |
I think I got the issue. My email is not a correct in the commit. I close this PR and raise a new one. |
Signed-off-by: Abhishek Agarwal [email protected]
What this PR does / why we need it:
Updates the CoreDNS image tags in the upgrade tests as well as improves the condition for checking whether the DNS deployment got upgraded successfully or not in upgrade tests.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #6143