Skip to content

📖 Update cert-manager links after migration#6116

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
apricote:cert-manager-repo
Feb 14, 2022
Merged

📖 Update cert-manager links after migration#6116
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
apricote:cert-manager-repo

Conversation

@apricote
Copy link
Copy Markdown
Member

What this PR does / why we need it:

cert-manager was migrated from the jetstack github organisation to a new cert-manager github organisation. While we already fixed the bug that this caused in #6050, the documentation was not updated.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): -

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 13, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @apricote!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @apricote. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 13, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 13, 2022
@palnabarun
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2022
@sbueringer
Copy link
Copy Markdown
Member

@apricote Thank you!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2022
@fabriziopandini
Copy link
Copy Markdown
Member

Thanks, @apricote for this cleanup, really appreciated it!
@sbueringer what about backporting given that it is mostly documentation and it can help our users?

@fabriziopandini
Copy link
Copy Markdown
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 078c649 into kubernetes-sigs:main Feb 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Feb 14, 2022
@apricote apricote deleted the cert-manager-repo branch February 14, 2022 14:14
@sbueringer
Copy link
Copy Markdown
Member

@sbueringer what about backporting given that it is mostly documentation and it can help our users?

+1

/cherry-pick release-1.1

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@sbueringer: new pull request created: #6123

Details

In response to this:

@sbueringer what about backporting given that it is mostly documentation and it can help our users?

+1

/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants