-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Implements Save and Restore for objectMover #4786
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @jpmcb! |
Hi @jpmcb. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I've signed the CLA for this project 🚀 |
and namespace to disc in configured directory. Restore will rebuild the object graph from configured directory files. Enables reboot / reload workflow.
/ok-to-test |
@jpmcb: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Implements the
Save
andRestore
methods on theobjectMover
Save will iterate objects in a given namespace, building the object graph, to then save them to a provided directory as a set of json files. These files will appear as:
Restore will iterate object files using a given glob in a configured directory to re-build an object graph. Once all files are iterated and the object graph is created, re-apply those objects to a given management / bootstrap cluster with provided client.
These methods can then be used to create a "backup / restore" cycle where a clusters objects are saved and restored latter.
Fixes #3441
Definitely want feedback on this and open to any proposed changes!
cc: @fabriziopandini