✨ Use uncached client and partial metadata for secret and configmaps#4023
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
vincepri
changed the title
fabriziopandini
left a comment
fabriziopandini
left a comment
There was a problem hiding this comment.
Only two small nits from my side
These changes allow the current stable Cluster API release to reduce its memory footprint by a large margin. Currently, we have multiple controllers that are either watching (like ClusterResourceSet) or querying (get/list) corev1.Secret and corev1.ConfigMap resources. When these kinds go through the case, all of the objects in the cluster end up being cached, not just the ones we're interested in. In production environments, there might be a large number of ConfigMap or Secret resources that we end up caching and watching for little gain. Signed-off-by: Vince Prignano <vincepri@vmware.com>
vincepri
force-pushed
the
uncached-configmaps-secrets
branch
from
66be2bb to
1ac7896
Compare
|
This should be good to go |
|
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
CecileRobertMichon
left a comment
CecileRobertMichon
left a comment
There was a problem hiding this comment.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
5 participants
These changes allow the current stable Cluster API release to reduce its
memory footprint by a large margin.
Currently, we have multiple controllers that are either watching (like
ClusterResourceSet) or querying (get/list) corev1.Secret and
corev1.ConfigMap resources.
When these kinds go through the case, all of the objects in the cluster
end up being cached, not just the ones we're interested in.
In production environments, there might be a large number of ConfigMap
or Secret resources that we end up caching and watching for little gain.
Signed-off-by: Vince Prignano vincepri@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3892
/milestone v0.4.0
/assign @CecileRobertMichon @detiber