Skip to content

⚠️ E2E framework resolves CNI_RESOURCES without using env vars#3896

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
arghya88:resolve-cni-resources
Nov 9, 2020
Merged

⚠️ E2E framework resolves CNI_RESOURCES without using env vars#3896
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
arghya88:resolve-cni-resources

Conversation

@arghya88
Copy link
Copy Markdown
Contributor

@arghya88 arghya88 commented Nov 3, 2020

What this PR does / why we need it:
Forward Ports #3846

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3874

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 3, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 3, 2020
@vincepri vincepri changed the title ⚠️Forward Port: E2E framework resolves CNI_RESOURCES without using env vars ⚠️ E2E framework resolves CNI_RESOURCES without using env vars Nov 3, 2020
@arghya88
Copy link
Copy Markdown
Contributor Author

arghya88 commented Nov 3, 2020

/assign @fabriziopandini

@arghya88
Copy link
Copy Markdown
Contributor Author

arghya88 commented Nov 4, 2020

APIDiff

sigs.k8s.io/cluster-api/test/framework/clusterctl
  Incompatible changes:
  - CreateRepositoryInput: old is comparable, new is not
  Compatible changes:
  - (*CreateRepositoryInput).RegisterClusterResourceSetConfigMapTransformation: added
  - CreateRepositoryInput.FileTransformations: added
  - RepositoryFileTransformation: added
+ EXIT_VALUE=1
+ set +o xtrace

@fabriziopandini
Copy link
Copy Markdown
Member

fabriziopandini commented Nov 4, 2020

/test pull-cluster-api-e2e-full-main

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Nov 4, 2020
@fabriziopandini
Copy link
Copy Markdown
Member

fabriziopandini commented Nov 4, 2020

/milestone v0.4.0

fabriziopandini
fabriziopandini reviewed Nov 4, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending addressing of the two comments

Comment thread test/e2e/e2e_suite_test.go Outdated
Comment thread test/framework/clusterctl/e2e_config.go Outdated
@arghya88 arghya88 force-pushed the resolve-cni-resources branch from ae98e7a to 65ad6b3 Compare November 4, 2020 11:48
fabriziopandini
fabriziopandini reviewed Nov 4, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2020
vincepri
vincepri approved these changes Nov 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 9, 2020 •
edited
Loading

@arghya88: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-e2e-full-main ae98e7a link /test pull-cluster-api-e2e-full-main
pull-cluster-api-apidiff-main 65ad6b3 link /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@arghya88
Copy link
Copy Markdown
Contributor Author

arghya88 commented Nov 9, 2020

/test pull-cluster-api-test-main

@k8s-ci-robot k8s-ci-robot merged commit defb99c into kubernetes-sigs:master Nov 9, 2020
@fabriziopandini fabriziopandini mentioned this pull request Nov 20, 2020
Merged
@arghya88 arghya88 deleted the resolve-cni-resources branch November 30, 2020 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@vincepri vincepri vincepri approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@fabriziopandini fabriziopandini

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v0.4

Development

Successfully merging this pull request may close these issues.

Forward-port E2E test now resolve CNI_RESOURCES without using env variables

4 participants

@arghya88 @fabriziopandini @k8s-ci-robot @vincepri