🏃 Adds a control plane struct to clean up the reconciler #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chuck Ha <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
lgtm
vincepri
reviewed
Mar 19, 2020
vincepri
reviewed
Mar 19, 2020
| Name: names.SimpleNameGenerator.GenerateName(c.KCP.Name + "-"), | ||
| Namespace: c.KCP.Namespace, | ||
| Labels: ControlPlaneLabelsForClusterWithHash(c.Cluster.Name, c.ConfigurationHash()), | ||
| OwnerReferences: []metav1.OwnerReference{owner}, |
There was a problem hiding this comment.
Do we want to make this a controller owner ref?
There was a problem hiding this comment.
the reconcile is not currently making this a controller owner reference, which is where this code originated. Do you think this should be a controller owner ref?
|
@chuckha These are all minor comments, can be reworked later, but feel free to hold if you wanna tackle them now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chuck Ha [email protected]
What this PR does / why we need it:
This is part of a larger effort to shrink the reconciler and reduce the use of annotations. This type adds a bunch of functions that do small tasks or access pieces of information in a clean way.
Because we are moving away from annotations on machines we need a way to idempotently find values. This holds those functions.
This type explicitly does not have any connections to any services and is just the logic that was found in the reconciler that is nicer outside of it.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related to #2702