🏃 util/tests: standardize gomega imports #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
I think this was the last batch, however, when all PRs get merged i will review the tree once again |
JoelSpeed
reviewed
Mar 16, 2020
| g.Expect(actualConfig.Clusters[tc.cluster]).NotTo(BeNil()) | ||
| g.Expect(actualConfig.Contexts[tc.expectedConfig.CurrentContext]).NotTo(BeNil()) | ||
| g.Expect(actualConfig.CurrentContext).To(Equal(tc.expectedConfig.CurrentContext)) | ||
| g.Expect(actualConfig.Contexts).To(Equal(tc.expectedConfig.Contexts)) |
There was a problem hiding this comment.
Could the order vary of actualConfig.Contexts? Might be better to use ConsistOf if ordering doesn't matter
Suggested change
| g.Expect(actualConfig.Contexts).To(Equal(tc.expectedConfig.Contexts)) | |
| g.Expect(actualConfig.Contexts).To(ConsistOf(tc.expectedConfig.Contexts)) |
There was a problem hiding this comment.
if use ConsistOf the test fail
--- FAIL: TestNew (0.29s)
/Users/cpanato/go/src/github.com/kubernetes-sigs/cluster-api/util/kubeconfig/kubeconfig_test.go:180:
Expected
<map[string]*api.Context | len:1>: {
"foo-admin@foo": {
LocationOfOrigin: "",
Cluster: "foo",
AuthInfo: "foo-admin",
Namespace: "",
Extensions: nil,
},
}
to consist of
<[]interface {} | len:1, cap:1>: [
{
"foo-admin@foo": {
LocationOfOrigin: "",
Cluster: "foo",
AuthInfo: "foo-admin",
Namespace: "",
Extensions: nil,
},
},
]
the missing elements were
<[]interface {} | len:1, cap:1>: [
{
"foo-admin@foo": {
LocationOfOrigin: "",
Cluster: "foo",
AuthInfo: "foo-admin",
Namespace: "",
Extensions: nil,
},
},
]
the extra elements were
<[]interface {} | len:1, cap:1>: [
{
LocationOfOrigin: "",
Cluster: "foo",
AuthInfo: "foo-admin",
Namespace: "",
Extensions: nil,
},
]
FAIL
FAIL sigs.k8s.io/cluster-api/util/kubeconfig 0.715s
FAIL
Error: Tests failed.
There was a problem hiding this comment.
Ack. Ignore that suggestion 😅 Don't think it works for maps
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
standardize gomega imports for
util/*/***testswill open other PR for the other folders to make easier the review
/cc @vincepri @detiber
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related to #2433