Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃 Be consistent with versioning in KubeadmControlPlane #2624

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Mar 10, 2020

Signed-off-by: Chuck Ha [email protected]

What this PR does / why we need it:
This requires the kubeadmControlPlane.spec.version to simply pass semver.ParseTolerant. That means it can have a v or not, it does not matter as the code will handle each case individually using a semver.Version.

/cc @vincepri
/assign @sedefsavas

@k8s-ci-robot
Copy link
Contributor

@chuckha: GitHub didn't allow me to assign the following users: sedefsavas.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Signed-off-by: Chuck Ha [email protected]

What this PR does / why we need it:
This requires the version to simply pass semver.ParseTolerant. That means it can have a v or not, it does not matter as the code will handle each case individually using a semver.Version.

/cc @vincepri
/assign @sedefsavas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from vincepri March 10, 2020 18:30
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@vincepri
Copy link
Member

/milestone v0.3.0
/assign @sedefsavas

@k8s-ci-robot
Copy link
Contributor

@vincepri: GitHub didn't allow me to assign the following users: sedefsavas.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/milestone v0.3.0
/assign @sedefsavas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v0.3.0 milestone Mar 10, 2020
@sedefsavas
Copy link

LGTM

@sedefsavas
Copy link

I am not a member, someone else has to lgtm I think.

@vincepri
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit b6aad25 into kubernetes-sigs:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants