-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 Be consistent with versioning in KubeadmControlPlane #2624
Conversation
Signed-off-by: Chuck Ha <[email protected]>
@chuckha: GitHub didn't allow me to assign the following users: sedefsavas. Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v0.3.0 |
@vincepri: GitHub didn't allow me to assign the following users: sedefsavas. Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM |
I am not a member, someone else has to lgtm I think. |
/lgtm |
Signed-off-by: Chuck Ha [email protected]
What this PR does / why we need it:
This requires the
kubeadmControlPlane.spec.version
to simply passsemver.ParseTolerant
. That means it can have av
or not, it does not matter as the code will handle each case individually using asemver.Version
./cc @vincepri
/assign @sedefsavas