📖clusterctl: doc config for air-gapped environments #2595
Conversation
k8s-ci-robot
added
cncf-cla: yes
| E.g. if you set the image tag for a provider components, e.g. the `infrastrcutrue-aws` provider, this most probably will lead to a not working management cluster because `kube-rbac-proxy` and | ||
| `cluster-api-aws-controller` usually are expected to have two different image tags. |
There was a problem hiding this comment.
| E.g. if you set the image tag for a provider components, e.g. the `infrastrcutrue-aws` provider, this most probably will lead to a not working management cluster because `kube-rbac-proxy` and | |
| `cluster-api-aws-controller` usually are expected to have two different image tags. | |
| Example: Let's say we're working with `infrastructure-aws`, overriding the image tag in the default provider components | |
| is going to result in a non-functional cluster due to `kube-rbac-proxy` and `cluster-api-aws-controller` having different tags. |
There was a problem hiding this comment.
I have dropped the example because it is hard to understand after moving the warning at the beginning of the paragraph
|
@vincepri comment addressed |
| images: | ||
| all: | ||
| repository: myorg.io/local-repo | ||
| cert-manager: |
There was a problem hiding this comment.
can all component images be overridden? If not, would it make sense to provide a list of images that can be?
There was a problem hiding this comment.
@CecileRobertMichon
ATM we are not supporting overrides for a single image, but only overrides at component level. In this example, "cert-manager" means all the images in the cert-manager manifest.
Available components are "cert-manger", "cluster-api" and all the installed providers: "bootstrap-kubeadm", "control-plane-kubeadm", "infrastracture-aws" etc.
Eventually, in the future/if there are specific needs, the mechanism can be extended for implementing image specific settings, but at the end the list of images depends on the provider manifests so it will be up to the provides to document which images are used.
| all: | ||
| repository: myorg.io/local-repo | ||
| cert-manager: | ||
| tag: v0.11.1 |
There was a problem hiding this comment.
Will the image specific override take precedence over the all setting?
There was a problem hiding this comment.
@CecileRobertMichon
The override works union, with the most specific override config taking precedence on the all config in case of conflicts.
So, in this example:
- for cluster-api images, the "all" override apply to all the images in the cluster-api manifest; same for other providers
- for cert-manager images, the "all" override U the "cert-manager" override apply to all the images in the cert-manager manifest
|
/approve This seems it should go in now :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
What this PR does / why we need it:
This PR document changes introduced by #2558 and by #2586
/assign @ncdc
/assign @vincepri