🏃tests: standardize gomega/ginkgo imports #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
cpanato
changed the title
k8s-ci-robot
added
size/L
cpanato
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
@cpanato This PR is related to the issue linked, but it doesn't fully fix it. There are a lot of other unit tests that have been written with the plain go-test style which should be converted, but that can happen later, this is a great first step! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@vincepri makes sense, updated the description I will look in the tests and update those that needed Thanks! |
vincepri
reviewed
Mar 6, 2020
detiber
reviewed
Mar 6, 2020
bootstrap/kubeadm/api/v1alpha2/kubeadmbootstrapconfig_types_test.go
Outdated
Show resolved
Hide resolved
bootstrap/kubeadm/api/v1alpha3/kubeadmbootstrapconfig_types_test.go
Outdated
Show resolved
Hide resolved
neolit123
reviewed
Mar 6, 2020
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
tests: standardize gomega/ginkgo imports
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related to #2433