🐛 util.EnsureOwnerRef should ignore version when comparing objects #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Want to write any units? |
detiber
reviewed
Feb 24, 2020
|
@ncdc yeah I'll, wanted to make sure the logic is sound first /hold |
k8s-ci-robot
added
the
do-not-merge/hold
vincepri
force-pushed
the
fix-util-ownerref
branch
from
aca43ee to
ed40ec9
Compare
|
/hold cancel |
k8s-ci-robot
added
size/L
|
/lgtm |
k8s-ci-robot
added
the
lgtm
vincepri
force-pushed
the
fix-util-ownerref
branch
from
ed40ec9 to
928c294
Compare
k8s-ci-robot
removed
the
lgtm
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
fix-util-ownerref
branch
from
928c294 to
86ccb66
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
Updates our utilities to make sure we're properly updating the references instead of duplicating them if they actually refer to the same object with different versions.
/assign @ncdc @detiber