✨ Remove configmap entry when doing a KubeadmControlPlane scale down #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
cncf-cla: yes
|
/hold I messed up the attribution on this PR, it should include @dlipovetsky |
k8s-ci-robot
added
the
do-not-merge/hold
|
/test pull-cluster-api-capd-e2e |
|
/milestone v0.3.0-rc.2 |
ncdc
added
the
area/control-plane
detiber
force-pushed
the
kcpRemoveConfigMapEntry
branch
2 times, most recently
from
8e80f87 to
397621c
Compare
|
Attribution fixed, leaving hold on prerequisites, though |
Co-authored-by: Daniel Lipovetsky <[email protected]>
detiber
force-pushed
the
kcpRemoveConfigMapEntry
branch
from
397621c to
3418ba7
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
lgtm, but will defer to a third party 🙂 |
| @@ -453,6 +454,21 @@ func (r *KubeadmControlPlaneReconciler) scaleDownControlPlane(ctx context.Contex | |||
| } | |||
| } | |||
|
|
|||
| if !internal.HasAnnotationKey(controlplanev1.ScaleDownConfigMapEntryRemovedAnnotation)(machineToDelete) { | |||
| if err := r.managementCluster.TargetClusterControlPlaneIsHealthy(ctx, util.ObjectKey(cluster), kcp.Name); err != nil { | |||
There was a problem hiding this comment.
Not a blocker, but we need to check provider contracts around load balancers to ensure they stop sending requests to machines.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes the machine's kubeadm configmap entry when doing a KubeadmControlPlane scale down
Related to #2242
Builds on #2379 #2380 #2381 #2382