Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃 Add Cecile to reviewer list #2376

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

vincepri
Copy link
Member

Signed-off-by: Vince Prignano [email protected]

What this PR does / why we need it:
@CecileRobertMichon expressed interested in getting more involved in Cluster API PR reviews. Let's make that happen :)

Signed-off-by: Vince Prignano <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
@detiber
Copy link
Member

detiber commented Feb 19, 2020

+1 from me
/hold
hold added for lazy consensus

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2020
@randomvariable
Copy link
Member

+1

@chuckha
Copy link
Contributor

chuckha commented Feb 20, 2020

+1!

@vincepri
Copy link
Member Author

/milestone v0.3.0-rc.2

@k8s-ci-robot k8s-ci-robot added this to the v0.3.0-rc.2 milestone Feb 20, 2020
@nader-ziada
Copy link
Contributor

+1

@vincepri
Copy link
Member Author

/retest

@vincepri
Copy link
Member Author

/hold cancel

We're past the usual 7-day period, I think we can probably merge this after the community meeting today, and congrats to @CecileRobertMichon !

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2020
@ncdc
Copy link
Contributor

ncdc commented Feb 26, 2020

/lgtm
🎉

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit a39618d into kubernetes-sigs:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants