Skip to content

📖Add documentation for metrics#1763

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
wfernandes:document-metrics
Nov 13, 2019
Merged

📖Add documentation for metrics#1763
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
wfernandes:document-metrics

Conversation

@wfernandes
Copy link
Copy Markdown
Contributor

Signed-off-by: Warren Fernandes wfernandes@pivotal.io

What this PR does / why we need it:
This PR documents the metrics exposed in the cluster api controller manager.
#1736 (comment)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #1477

Signed-off-by: Warren Fernandes <wfernandes@pivotal.io>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 13, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 13, 2019
@wfernandes
Copy link
Copy Markdown
Contributor Author

@vincepri Just FYI here's the documentation for the metrics.

@vincepri vincepri added this to the v0.3.0 milestone Nov 13, 2019
Copy link
Copy Markdown
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

💯

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri, wfernandes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 21b449a into kubernetes-sigs:master Nov 13, 2019
@wfernandes wfernandes deleted the document-metrics branch November 13, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants