Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add CABPK abbreviation and v1alpha2-ize other abbreviations #1432

Merged
merged 1 commit into from
Sep 23, 2019
Merged

📖 Add CABPK abbreviation and v1alpha2-ize other abbreviations #1432

merged 1 commit into from
Sep 23, 2019

Conversation

erwinvaneyk
Copy link
Contributor

This PR adds CABPK (kubeadm bootstrap provider) to the abbreviation overview. It further rewords the abbreviations in the book to emphasize the difference between the infrastructure and bootstrap providers introduced in v1alpha2

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 23, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 23, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @erwinvaneyk. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 23, 2019
vincepri
vincepri approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @ncdc

@vincepri
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erwinvaneyk, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@erwinvaneyk erwinvaneyk changed the title 📖 Add CABPK abbreviation and v1alpha2-ize other abbreviations 📖 Add CABPK abbreviation and v1alpha2-ize other abbreviations Sep 23, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2019
@ncdc
Copy link
Contributor

ncdc commented Sep 23, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2c4cbfa into kubernetes-sigs:master Sep 23, 2019
detiber
detiber reviewed Sep 23, 2019
View reviewed changes
docs/book/src/reference/abbreviations.md
CAPO | Cluster API Provider OpenStack
CAPV | Cluster API Provider vSphere
CAPZ | Cluster API Provider Azure
CAPA | Cluster API AWS infrastructure provider
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CAPA | Cluster API AWS infrastructure provider
CAPA | Cluster API infrastructure Provider AWS

docs/book/src/reference/abbreviations.md
CAPV | Cluster API Provider vSphere
CAPZ | Cluster API Provider Azure
CAPA | Cluster API AWS infrastructure provider
CAPD | Cluster API Docker infrastructure provider
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CAPD | Cluster API Docker infrastructure provider
CAPD | Cluster API infrastructure Provider Docker

docs/book/src/reference/abbreviations.md
CAPZ | Cluster API Provider Azure
CAPA | Cluster API AWS infrastructure provider
CAPD | Cluster API Docker infrastructure provider
CAPO | Cluster API OpenStack infrastructure provider
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CAPO | Cluster API OpenStack infrastructure provider
CAPO | Cluster API infrastructure Provider OpenStack

docs/book/src/reference/abbreviations.md
CAPA | Cluster API AWS infrastructure provider
CAPD | Cluster API Docker infrastructure provider
CAPO | Cluster API OpenStack infrastructure provider
CAPV | Cluster API vSphere infrastructure provider
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CAPV | Cluster API vSphere infrastructure provider
CAPV | Cluster API infrastructure Provider vSphere

docs/book/src/reference/abbreviations.md
CAPD | Cluster API Docker infrastructure provider
CAPO | Cluster API OpenStack infrastructure provider
CAPV | Cluster API vSphere infrastructure provider
CAPZ | Cluster API Azure infrastructure provider
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CAPZ | Cluster API Azure infrastructure provider
CAPZ | Cluster API infrastructure Provider Azure

docs/book/src/reference/abbreviations.md
CAPO | Cluster API OpenStack infrastructure provider
CAPV | Cluster API vSphere infrastructure provider
CAPZ | Cluster API Azure infrastructure provider
CABPK | Cluster API Kubeadm bootstrap provider
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CABPK | Cluster API Kubeadm bootstrap provider
CABPK | Cluster API Bootstrap Provider Kubeadm

@detiber
Copy link
Member

detiber commented Sep 23, 2019

doh, review in too late :(

@ncdc
Copy link
Contributor

ncdc commented Sep 23, 2019

follow-up 😛

@erwinvaneyk
Copy link
Contributor Author

@detiber it's the effort that counts! 😁

@erwinvaneyk erwinvaneyk deleted the add-cabpk-abbreviation branch September 23, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detiber detiber detiber left review comments

@vincepri vincepri vincepri approved these changes

Assignees

@ncdc ncdc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erwinvaneyk @k8s-ci-robot @vincepri @ncdc @detiber