🏃 Make getMachinesInCluster a helper function #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
tahsinrahman
force-pushed
the
machine-cluster
branch
from
ff53dd5 to
6129c87
Compare
k8s-ci-robot
added
size/L
chuckha
reviewed
Sep 13, 2019
controllers/machine_helpers.go
Outdated
|
|
||
| // getMachinesInCluster returns all of the Machine objects | ||
| // that belong to the cluster with given namespace/name | ||
| func getMachinesInCluster(ctx context.Context, c client.Client, namespace, name string) ([]*clusterv1.Machine, error) { |
There was a problem hiding this comment.
I would like to see a test case for this function and perhaps a rename to getActiveMachinesInCluster. It could be read as "get all machines in a cluster" but the function is getting the non-deleted (is active the right word?) machines.
Regardless of a rename, this functionality should be reflected in the godoc.
tahsinrahman
force-pushed
the
machine-cluster
branch
from
6129c87 to
03abc64
Compare
|
nice! /lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber, tahsinrahman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1414