📖 Quickstart / add other sections #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-cluster-api-test |
vincepri
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
/cc @pickledrick |
|
@vincepri: GitHub didn't allow me to request PR reviews from the following users: pickledrick. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
vincepri
force-pushed
the
structure-book
branch
from
eab0e88 to
cda387d
Compare
vincepri
changed the title
k8s-ci-robot
added
size/M
vincepri
force-pushed
the
structure-book
branch
2 times, most recently
from
0f7dc8b to
057e3fb
Compare
k8s-ci-robot
added
size/L
detiber
reviewed
Sep 5, 2019
vincepri
force-pushed
the
structure-book
branch
5 times, most recently
from
8922847 to
66bc3fb
Compare
timothysc
suggested changes
Sep 5, 2019
|
/assign @timothysc |
vincepri
force-pushed
the
structure-book
branch
from
66bc3fb to
d0ebaf1
Compare
poidag-zz
reviewed
Sep 5, 2019
vincepri
force-pushed
the
structure-book
branch
from
a66aca0 to
b6abf03
Compare
k8s-ci-robot
added
size/L
detiber
reviewed
Sep 6, 2019
vincepri
force-pushed
the
structure-book
branch
from
b6abf03 to
261bd6a
Compare
k8s-ci-robot
added
size/XL
vincepri
force-pushed
the
structure-book
branch
3 times, most recently
from
44eb8c3 to
1cf80a3
Compare
detiber
reviewed
Sep 6, 2019
vincepri
force-pushed
the
structure-book
branch
3 times, most recently
from
73c946a to
ef1bf9e
Compare
detiber
reviewed
Sep 6, 2019
vincepri
force-pushed
the
structure-book
branch
5 times, most recently
from
5b6155b to
e6214ae
Compare
Signed-off-by: Vince Prignano <[email protected]>
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
structure-book
branch
from
e6214ae to
078dfd8
Compare
detiber
reviewed
Sep 6, 2019
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
structure-book
branch
from
078dfd8 to
2e4a53f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1369