Skip to content

🌱 Cleanup KCP code: variable/func renames, func order #12793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

🌱 Cleanup KCP code: variable/func renames, func order #12793

merged 1 commit into from
Sep 24, 2025
+158 −227

Conversation

@sbueringer
Copy link
Member

@sbueringer sbueringer commented Sep 23, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #12291

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Sep 23, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 23, 2025
@sbueringer sbueringer mentioned this pull request Sep 22, 2025
Open
76 tasks
@sbueringer sbueringer added the area/provider/control-plane-kubeadm Issues or PRs related to KCP label Sep 23, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Sep 23, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Sep 23, 2025

/test pull-cluster-api-e2e-main

@sbueringer
Copy link
Member Author

sbueringer commented Sep 23, 2025

/assign @chrischdi @fabriziopandini

fabriziopandini
fabriziopandini reviewed Sep 23, 2025
View reviewed changes
@sbueringer
Copy link
Member Author

sbueringer commented Sep 24, 2025

Thx for the quick review. Should be all addressed

@sbueringer
Copy link
Member Author

sbueringer commented Sep 24, 2025

/test pull-cluster-api-e2e-main

fabriziopandini
fabriziopandini reviewed Sep 24, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 24, 2025

LGTM label has been added.

Git tree hash: c9b10af318b17bf59e6fcf05269d0f2f0626c6fb

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Sep 24, 2025

Independent flake

/override pull-cluster-api-e2e-main

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 24, 2025

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main

In response to this:

Independent flake

/override pull-cluster-api-e2e-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit cd8a2c8 into kubernetes-sigs:main Sep 24, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Sep 24, 2025
@sbueringer sbueringer deleted the pr-kcp-refactoring branch September 24, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@chrischdi chrischdi

@fabriziopandini fabriziopandini

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

4 participants

@sbueringer @k8s-ci-robot @fabriziopandini @chrischdi