[0.1] set OwnerRef in more cases #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
liztio
force-pushed
the
set-owners
branch
2 times, most recently
from
0b096a2 to
b918159
Compare
|
/assign @ncdc |
detiber
reviewed
Jul 29, 2019
pkg/controller/machinedeployment/machinedeployment_controller.go
Outdated
Show resolved
Hide resolved
|
/test pull-cluster-api-test pull-cluster-api-integration |
|
/test pull-cluster-api-test |
ncdc
reviewed
Jul 30, 2019
Closed
|
Tagging as Liz is out of the office and my only comment is a typo we can fix in a follow-up. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liztio, ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Right now the cluster manager will only set an ownerreference if no owner exists at creation time. This could potentially cause issues if an object is owned by a not-Cluster API object. Instead, we will check all references to see if they point to a cluster-api object, and "adopt" them if they do not.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1190
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: