🐛 Align "random" deletion policy behavior regarding deletion annotations

[elizabeth-dev]

What this PR does / why we need it:
Right now, the oldest and newest deletion policies prioritize machines that have the cluster.x-k8s.io/delete-machine annotation over unhealthy machines when deciding which machines need to be deleted. This wasn't the case with the random deletion policy. This change aligns the latter to the rest, making it honor the deletion annotation.

The unit tests for that part of the code have also been modified to be more strict when comparing machines with this annotation, always comparing them with unhealthy machines.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #11387

/area machineset

[k8s-ci-robot]

Welcome @elizabeth-dev!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @elizabeth-dev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[elizabeth-dev]

Not sure if this could technically qualify as a breaking change. I've inquired the Slack channel to know other people's opinions, will update the PR if deemed necessary.

[enxebre]

/ok-to-test
/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: d649f193592ce017d6501950665b018bfe656a71

[sbueringer]

Not sure if this could technically qualify as a breaking change. I've inquired the Slack channel to know other people's opinions, will update the PR if deemed necessary.

I think we're good. It's fine to flag it as bugfix. It seems a comparatively minor change so I wouldn't mark it as breaking change. I just wouldn't backport it, so that this change will only be picked up by a minor release and not via a patch release.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment