Skip to content

📖 Document terminationMessagePolicy suggestion for providers#10594

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
shiftstack:termination-provider-doc
May 13, 2024
Merged

📖 Document terminationMessagePolicy suggestion for providers#10594
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
shiftstack:termination-provider-doc

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented May 13, 2024

Adds a recommendation for providers in line with #10580.

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2024
@enxebre
Copy link
Member

enxebre commented May 13, 2024

thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 94cf70dcb913c4b6dfce13bebadae76461fbeff7

@sbueringer
Copy link
Member

Thank you very much!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit fe5001b into kubernetes-sigs:main May 13, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants