Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Set previous release tag version for RELEASE CANDIDATE/BETA RELEASE #10435

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

chandankumar4
Copy link
Contributor

What this PR does / why we need it:

  • Add Previous release tag version for RELEASE CANDIDATE/BETA RELEASE

For RELEASE CANDIDATE/BETA RELEASE

$ RELEASE_TAG=v1.7.0-rc.1 PREVIOUS_VERSION_TAG=tags/v1.7.0-rc.0 make release-notes

go build -C hack/tools -o /Users/ckumar14/go/src/github.com/sigs.k8s.io/cluster-api/bin/notes -tags tools sigs.k8s.io/cluster-api/hack/tools/release/notes
./bin/notes --release v1.7.0-rc.1 --previous-release-version tags/v1.7.0-rc.0 > CHANGELOG/v1.7.0-rc.1.md
2024/04/14 10:46:08 Computing diff between v1.7.0-rc.0 and heads/release-1.7
2024/04/14 10:46:08 Calling endpoint repos/kubernetes-sigs/cluster-api/compare/v1.7.0-rc.0...release-1.7?per_page=250&page=1&
2024/04/14 10:46:09 Total of 1 pages and 31 elements read
2024/04/14 10:46:09 Reading ref heads/release-1.7 for upper limit
.....

For Release TAG

$ RELEASE_TAG=v1.7.0 make release-notes

go build -C hack/tools -o /Users/ckumar14/go/src/github.com/sigs.k8s.io/cluster-api/bin/notes -tags tools sigs.k8s.io/cluster-api/hack/tools/release/notes
./bin/notes --release v1.7.0 --previous-release-version "" > CHANGELOG/v1.7.0.md
2024/04/14 10:56:07 Computing diff between tags/v1.6.0 and heads/release-1.7
2024/04/14 10:56:07 Calling endpoint repos/kubernetes-sigs/cluster-api/compare/v1.6.0...release-1.7?per_page=250&page=1&
2024/04/14 10:56:09 Calling endpoint repos/kubernetes-sigs/cluster-api/compare/v1.6.0...release-1.7?per_page=250&page=2&
.....

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10396

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @chandankumar4. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 14, 2024
@chandankumar4 chandankumar4 changed the title Set previous release tag version for RELEASE CANDIDATE/BETA RELEASE 🐛 Set previous release tag version for RELEASE CANDIDATE/BETA RELEASE Apr 14, 2024
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Signed-off-by: chandankumar4 <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2024
docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 5, 2024
@chandankumar4 chandankumar4 requested a review from typeid May 5, 2024 06:39
@chandankumar4 chandankumar4 requested a review from cahillsf May 13, 2024 14:49
Makefile Show resolved Hide resolved
@sbueringer
Copy link
Member

@chandankumar4 do you have time to address the findings?

@chandankumar4
Copy link
Contributor Author

@chandankumar4 do you have time to address the findings?

Sure, Sorry I totally missed this PR, I'll update the PR. Thanks

@chandankumar4
Copy link
Contributor Author

@chandankumar4 do you have time to address the findings?

I have resolved the review comment, @sbueringer do you have time to look at it once? Thanks

@chandankumar4
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@chandankumar4: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer sbueringer added the area/release Issues or PRs related to releasing label Aug 6, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Aug 6, 2024
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 6, 2024
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 6, 2024
Makefile Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

@chandankumar4
Copy link
Contributor Author

@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 759c98aadb699900060f54621393a19f602be831

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit cefe990 into kubernetes-sigs:main Aug 6, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Aug 6, 2024
@chandankumar4 chandankumar4 deleted the release-notes branch August 6, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release notes generation documentation and make target don't work for release candidates
6 participants