-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Set previous release tag version for RELEASE CANDIDATE/BETA RELEASE #10435
🐛 Set previous release tag version for RELEASE CANDIDATE/BETA RELEASE #10435
Conversation
Signed-off-by: chandankumar4 <[email protected]>
Hi @chandankumar4. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: chandankumar4 <[email protected]>
Signed-off-by: chandankumar4 <[email protected]>
Signed-off-by: chandankumar4 <[email protected]>
@chandankumar4 do you have time to address the findings? |
Sure, Sorry I totally missed this PR, I'll update the PR. Thanks |
I have resolved the review comment, @sbueringer do you have time to look at it once? Thanks |
/ok-to-test |
@chandankumar4: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@chandankumar4 Looks like we also have a linter finding: https://github.com/kubernetes-sigs/cluster-api/actions/runs/10268177616/job/28410554105?pr=10435 |
Signed-off-by: chandankumar4 <[email protected]>
3ea4d61
to
83e1903
Compare
Yes, I have it resolved |
Thx! /lgtm |
LGTM label has been added. Git tree hash: 759c98aadb699900060f54621393a19f602be831
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
For RELEASE CANDIDATE/BETA RELEASE
For Release TAG
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #10396