Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link in https://master.cluster-api.sigs.k8s.io/clusterctl/commands/config-cluster.html#variables #2340

Closed
ncdc opened this issue Feb 14, 2020 · 3 comments · Fixed by #2342
Closed

Broken link in https://master.cluster-api.sigs.k8s.io/clusterctl/commands/config-cluster.html#variables #2340

ncdc opened this issue Feb 14, 2020 · 3 comments · Fixed by #2342
Assignees
@dpandhi-git
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.3.0

Comments

@ncdc
Copy link
Contributor

ncdc commented Feb 14, 2020

The clusterctl configuration link at the bottom of https://master.cluster-api.sigs.k8s.io/clusterctl/commands/config-cluster.html#variables points to clusterctl/commands/configuration.html, which is a 404. The correct URL is clusterctl/configuration.html

/help
/good-first-issue
/kind documentation
/kind bug
/milestone v0.3.0
/priority important-soon
@k8s-ci-robot
Copy link
Contributor

@ncdc:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

The clusterctl configuration link at the bottom of https://master.cluster-api.sigs.k8s.io/clusterctl/commands/config-cluster.html#variables points to clusterctl/commands/configuration.html, which is a 404. The correct URL is clusterctl/configuration.html

/help
/good-first-issue
/kind documentation
/kind bug
/milestone v0.3.0
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v0.3.0 milestone Feb 14, 2020
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. kind/bug Categorizes issue or PR as related to a bug. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 14, 2020
dpandhi-git added a commit to dpandhi-git/cluster-api that referenced this issue Feb 14, 2020
@dpandhi-git
Updated clusterctl configuration link at the bottom of https://master…
4088c24 
….cluster-api.sigs.k8s.io/clusterctl/commands/config-cluster.html#variables to use clusterctl/configuration.html instead of clusterctl/commands/configuration.html(broken link) kubernetes-sigs#2340
dpandhi-git added a commit to dpandhi-git/cluster-api that referenced this issue Feb 14, 2020
@dpandhi-git
Updated clusterctl configuration link at the bottom of https://master…
f08f197 
….cluster-api.sigs.k8s.io/clusterctl/commands/config-cluster.html#variables to use clusterctl/configuration.html instead of clusterctl/commands/configuration.html(broken link) kubernetes-sigs#2340
@dpandhi-git dpandhi-git mentioned this issue Feb 14, 2020
Merged
@k8s-ci-robot
Copy link
Contributor

@dpandhi-git: GitHub didn't allow me to assign the following users: dpandhi.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign dpandhi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dpandhi-git
Copy link
Contributor

/assign dpandhi-git

k8s-ci-robot added a commit that referenced this issue Feb 16, 2020
@k8s-ci-robot
Merge pull request #2342 from dpandhi-git/broken_link_clusterctl_cmd
7eead35 
📖Fixes broken link clusterctl configuration #2340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpandhi-git dpandhi-git

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

📖Fixes broken link clusterctl configuration #2340 dpandhi-git/cluster-api
3 participants
@ncdc @dpandhi-git @k8s-ci-robot