Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: hardikdr <[email protected]>
  • Loading branch information
scruplelesswizard and hardikdr committed Nov 22, 2018
1 parent 4e14d16 commit 1e19979
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 12 deletions.
11 changes: 5 additions & 6 deletions pkg/apis/cluster/v1alpha1/machine_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,13 +154,12 @@ type MachineStatus struct {

// LastOperation describes the last-operation performed by the machine-controller.
// This API should be useful as a history in terms of the latest operation performed on the
// specific machine. It should also convey the state of the latest-operation for example if // it is still on-going, failed or completed successfully.
// specific machine. It should also convey the state of the latest-operation for example if
// it is still on-going, failed or completed successfully.
// +optional
LastOperation LastOperation `json:"lastOperation,omitempty"`
LastOperation *LastOperation `json:"lastOperation,omitempty"`

// Phase represents an ongoing-phase a machine is going through. It is expected to be
// transient. Higher-level controllers should rely on MachinePhases to take the right
// decision such as replacing the Failed machines.
// Phase represents the current phase of machine actuation.
// Eg. Pending, Running, Terminating, Failed etc.
// +optional
Phase *string `json:"phase,omitempty"`
Expand All @@ -169,7 +168,7 @@ type MachineStatus struct {
// LastOperation represents the detail of the last performed operation on the MachineObject.
type LastOperation struct {
// Description is the human-readable description of the last operation.
Description string `json:"description,omitempty"`
Description *string `json:"description,omitempty"`

// LastUpdateTime is the timestamp at which LastOperation API was last-updated.
LastUpdateTime *metav1.Time `json:"lastUpdateTime,omitempty"`
Expand Down
21 changes: 15 additions & 6 deletions pkg/apis/cluster/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1e19979

Please sign in to comment.