Skip to content

🏃 Refactor: use Service struct field more #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
May 25, 2021
Merged

🏃 Refactor: use Service struct field more #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/cloud/services/compute/bastion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func (s *Service) CreateBastion(openStackCluster *infrav1.OpenStackCluster, clus
RootVolume: openStackCluster.Spec.Bastion.Instance.RootVolume,
}

securityGroups, err := getSecurityGroups(s, openStackCluster.Spec.Bastion.Instance.SecurityGroups)
securityGroups, err := s.getSecurityGroups(openStackCluster.Spec.Bastion.Instance.SecurityGroups)
if err != nil {
return nil, err
}
Expand All @@ -45,7 +45,7 @@ func (s *Service) CreateBastion(openStackCluster *infrav1.OpenStackCluster, clus
var nets []infrav1.Network
if len(openStackCluster.Spec.Bastion.Instance.Networks) > 0 {
var err error
nets, err = getServerNetworks(s.networkClient, openStackCluster.Spec.Bastion.Instance.Networks)
nets, err = s.getServerNetworks(openStackCluster.Spec.Bastion.Instance.Networks)
if err != nil {
return nil, err
}
Expand All @@ -59,7 +59,7 @@ func (s *Service) CreateBastion(openStackCluster *infrav1.OpenStackCluster, clus
}
input.Networks = &nets

out, err := createInstance(s, openStackCluster, clusterName, input)
out, err := s.createInstance(openStackCluster, clusterName, input)
if err != nil {
return nil, err
}
Expand Down
Loading