Skip to content

🐛 use sec groups from the current project, wait for lb from last reconcile#523

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
sbueringer:pr-admin-sec-groups
Mar 31, 2020
Merged

🐛 use sec groups from the current project, wait for lb from last reconcile#523
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
sbueringer:pr-admin-sec-groups

Conversation

@sbueringer
Copy link
Copy Markdown
Member

What this PR does / why we need it:

This PR fixes to issues:

  • When using an admin user it wasn't possible to assign security groups to machines because the security group list call returned sec groups from all projects, now it's filtered to the current one
  • When reconciling load balancer there was an issue when the lb was still "pending create" from the last reconcile. Now the controller also waits even when the lb already exists from before.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 25, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2020
@sbueringer
Copy link
Copy Markdown
Member Author

/assign @hidekazuna
/assign @jichenjc
/assign @prankul88

@sbueringer
Copy link
Copy Markdown
Member Author

sbueringer commented Mar 27, 2020

@jichenjc can you also take a look at this one? (as I wanted to merge it first :))

@sbueringer
Copy link
Copy Markdown
Member Author

@jichenjc can you also take a look at this one? (as I wanted to merge it first :))

push @jichenjc

@jichenjc
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2020
@jichenjc
Copy link
Copy Markdown
Contributor

I didn't do deep check on this but generally looks good, let's merge this and see whether we need further enhancement :)

@k8s-ci-robot k8s-ci-robot merged commit 9e63a34 into kubernetes-sigs:master Mar 31, 2020
@sbueringer sbueringer deleted the pr-admin-sec-groups branch March 31, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants