⚠️ fixup namespace handling in 0.3.0#521
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom Mar 23, 2020
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Member
Author
|
/assign @jichenjc |
sbueringer
changed the title
Contributor
|
looks good, |
Contributor
|
@sbueringer @jichenjc This worked fine in my environment. |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just did a final manual test and saw that the quickstart with 0.3.0 only worked when --target-namespace was equal to the cluster-name. This PRs fixes our templates so that the namespace where all resources are deployed is equal to our secret references in the CAPO resources
P.S. I already replaced the uploaded cluster-templates in the published 0.3.0 release to avoid that somebody who is trying CAPO out right now directly fails with this error, which would be bad :)