Skip to content

📖 Fix development.md#510

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
hidekazuna:fix_development.md
Mar 4, 2020
Merged

📖 Fix development.md#510
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
hidekazuna:fix_development.md

Conversation

@hidekazuna
Copy link
Contributor

What this PR does / why we need it:

Follow up 0.2.0.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2020
@hidekazuna hidekazuna changed the title 📖 Fix development.md 📖 Fix development.md Mar 4, 2020
@hidekazuna
Copy link
Contributor Author

/assign @jichenjc

@jichenjc
Copy link
Contributor

jichenjc commented Mar 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2020
@jichenjc
Copy link
Contributor

jichenjc commented Mar 4, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hidekazuna, jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit da6041d into kubernetes-sigs:master Mar 4, 2020
@hidekazuna hidekazuna deleted the fix_development.md branch March 4, 2020 04:21
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants