finalize doc & examples for v0.2.0#488
Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:masterfrom Oct 29, 2019
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
This was referenced Oct 26, 2019
Closed
prankul88
reviewed
Oct 27, 2019
Contributor
|
generally looks good, don't have to time to go through this recently |
detiber
reviewed
Oct 28, 2019
Member
Author
|
@prankul88 can you take another look and tell us if it's okay for you. So somebody else, e.g. @jichenjc can lgtm & approve for you |
Contributor
|
@sbueringer looks good to me. |
Member
Author
Thx :) @jichenjc Can you approve/lgtm the PR? |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
6 tasks
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
* finalize doc & examples for v0.2.0 * review fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finalizes doc & examples for v0.2.0
See also #480